feat: WP-197 use @layer's / help migrate Frontera#856
Merged
wesleyboar merged 14 commits intoOct 1, 2024
Conversation
Frontera migration — TACC/Core-CMS-Custom#293 — uses @layers, but then Frontera styles yield to Core-CMS styles. They yield to Core-CMS because Core-CMS — with `TACC_CORE_STYLES_VERSION=0` — has all its styles in an anonymous layer. (CSS in an anonymous layer beats CSS in a named layer.)
wesleyboar
force-pushed
the
feat/WP-197-use-css-layers-to-help-migrate-frontera
branch
from
July 25, 2024 19:32
865cd70 to
ebe86e4
Compare
22 tasks
wesleyboar
marked this pull request as ready for review
September 20, 2024 23:54
So, change `project` to `project.core`.
Recent CSS fix for header was only applied to v1-origin sites. The fix should be applied to v4.18+ sites.
wesleyboar
deleted the
feat/WP-197-use-css-layers-to-help-migrate-frontera
branch
October 1, 2024 00:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Use
@layerfor Core-CMS stylesheets loaded whenTACC_CORE_STYLES_VERSION=0.Details
Frontera migration — TACC/Core-CMS-Custom#293 — uses
@layers, but then Frontera styles yield to Core-CMS styles.They yield to Core-CMS because Core-CMS — with
TACC_CORE_STYLES_VERSION=0— has all its styles in an anonymous layer.(CSS in an anonymous layer beats CSS in a named layer.)
Related
Changes
@layer's@layer(only to match
TACC_CORE_STYLES_VERSION=2CMS use of@layer's)Testing / UI
feat: WP-197 migrate frontera portal Core-CMS-Custom#293
enhance(ecep): ecep_cms → ecep_assets Core-CMS-Custom#321
feat: epoc_assets Core-CMS-Custom#320
Notes
PR Problems That Have Since Been Fixed
#css-booststrapnode cuz it does not exist now.