GH-101: Portal Nav Mobile - Layout Change#241
Merged
wesleyboar merged 3 commits intoJun 3, 2021
Merged
Conversation
- Confert "mobile button" layout from flex to grid. - Update "mobile button" instances accordingly.
Do not set `display: grid` in `x-mobile-button`.
- Add more nav media queries. - Use new constants. - Shove Portal Nav up into Search Bar row (do not properly share 1 row). - Ensure icon spacing is accurate given different nav states. - Add background for Portal Nav & Search Bar "row". - Make all mobile dropdown menu items have same font size. - Retain wide portal nav for one breakpoint within collapsed navbar. - Limit Portal Nav load transition to when navbar is expanded. - Add new constants.
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Change portal nav layout to be "pushdown" menu instead of "dropdown" menu.¹
¹ See "Known Issues" 1.
Issues
Changes
Testing
¹ See "Known Issues" 1.
² Can not test logged out Portal Nav on Portal.
Notes
Known Issues
Portal nav location is not as verbally described by designer.
The result matches the static design, and invents solutions for what the design does not define.
The designer has verbally described the desired (undrawn) behavior for the mobile portal nav. It should be at the right of the navbar toggle, and always (when visible¹) a similar size to the navbar toggle (when visible¹).
But this change only changes mobile portal nav menu from a "dropdown" menu to a "pushhdown" menu and experiments with wide and narrow mobile portal nav toggle/link designs. The change here is simpler, tests the ability to move the portal nav outside its position in the markup, and tests nav-specific breakpoints narrow and wider than just when the navbar collapses/expands.
¹ The mobile portal nav and the navbar toggle are not visible on wide screens.
Portal nav on narrow screen has various bugs on Portal & Docs.
The bugs will be fixed in a planned Portal & Docs bugfix PR.