Hack: GH-101: Use Cortal icons sans markup change#229
Merged
wesleyboar merged 1 commit intoMay 24, 2021
Merged
Conversation
- Tweak a comment (related cuz it's also icon hack). - Migrate Portal nav styles to `s-portal-nav.css`. - Add hack to swap FA icons with Cortal icons. - Update CSS sample `s-portal-nav.html`.
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Use Cortal icons for Portal nav.
Issues
Changes
s-portal-nav.css.s-portal-nav.html.Testing
Load on wide screen (so header navigation uses desktop layout).
Ensure icons are new, from Cortal, and not from FontAwesome.
Details
Ensure no other styles have changed.
Load on small screen (so header navigation uses mobile layout).
Ensure Portal nav is usable and has icons.
Ensure no other styles have changed.