Skip to content

chore(deps): core-styles v2.55 + section--accent#1144

Merged
wesleyboar merged 5 commits into
mainfrom
chore/core-styles-v2-55
Apr 9, 2026
Merged

chore(deps): core-styles v2.55 + section--accent#1144
wesleyboar merged 5 commits into
mainfrom
chore/core-styles-v2-55

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Apr 8, 2026

Copy link
Copy Markdown
Member

Overview

Update to Core-Styles v2.55 for:

  • accessibility fixes to .sections
  • new .section style accent
  • support Bootstrap v4 media object
  • new script to create page to test sections

Related

Changes

  • updated Core-Styles
  • added section--accent`

Testing

  1. make build
  2. make start
  3. Create a page with:
    • two sections, one after the other
    • each section has <h2> and text
    • try different section combinations
  4. Verify UI matches sections of:

UI

Screenshot 2026-04-08 at 20 48 11

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Update Core-Styles to v2.55.0 with accessibility improvements

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update Core-Styles dependency to v2.55.0
• Includes accessibility fixes for sections
• Adds new section--accent style variant
• Enables Bootstrap v4 media object support
Diagram
flowchart LR
  A["package.json"] -- "update dependency" --> B["@tacc/core-styles v2.55.0"]
  B -- "provides" --> C["Accessibility fixes"]
  B -- "provides" --> D["section--accent style"]
  B -- "provides" --> E["Bootstrap v4 media support"]
Loading

Grey Divider

File Changes

1. package.json Dependencies +1/-1

Bump Core-Styles dependency to v2.55.0

• Updated @tacc/core-styles from v2.54.1 to v2.55.0
• Brings in accessibility improvements and new styling options

package.json


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Apr 8, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)
🐞\ ☼ Reliability (1)

Grey Divider


Action required

1. Node version incompatibility 🐞
Description
After bumping @tacc/core-styles to 2.55.0, the dependency declares engines.node >=20.x, but
the Docker build stage runs node:18 and executes npm ci/npm run build, which runs Core-Styles
code under an unsupported Node version. This can cause npm ci EBADENGINE failures (if engines are
enforced) and/or runtime build failures when bin/build-css.js imports Core-Styles.
Code

package.json[24]

+    "@tacc/core-styles": "^2.55.0"
Evidence
The PR changes the Core-Styles version, and the resolved package metadata for
@tacc/core-styles@2.55.0 requires Node 20+, while the repository’s asset build runs in a Node 18
Docker stage and directly require()s Core-Styles during npm run build.

package-lock.json[1405-1417]
Dockerfile[39-51]
bin/build-css.js[3-31]
package.json[9-12]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`@tacc/core-styles@2.55.0` requires Node `>=20.x` but the repo builds CSS in Docker using `node:18` and the repo-level `package.json` advertises `node >=16`. This mismatch can break `npm ci` (engine enforcement) and/or the runtime execution of `bin/build-css.js` that imports Core-Styles.

### Issue Context
- Docker build stage installs deps via `npm ci` and runs `npm run build`.
- `npm run build` calls `bin/build-css.js`, which `require()`s `@tacc/core-styles`.
- Lockfile shows `@tacc/core-styles@2.55.0` requires Node 20+.

### Fix Focus Areas
- Update Node build image to Node 20+ (and keep npm compatible):
 - Dockerfile[39-51]
- Align the repo’s declared engines with what is actually required (or revert/pin core-styles to a Node-18-compatible version if you must stay on Node 18):
 - package.json[9-12]
 - package.json[23-25]
- Validate the lockfile still resolves correctly after the Node/version decision:
 - package-lock.json[1405-1417]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment thread package.json
Expose o-section--style-accent alongside light, muted, and dark in
DJANGOCMS_BOOTSTRAP4_GRID_CONTAINERS so Container matches Style plugin options.

Made-with: Cursor
Published QA page stacks Style section variants and a Bootstrap 4 Container
with accent classes. Document usage in management commands README.
Replace deletes draft-only trees to avoid django CMS 3 TreeNode errors.

Made-with: Cursor
@wesleyboar wesleyboar merged commit 208611d into main Apr 9, 2026
@wesleyboar wesleyboar deleted the chore/core-styles-v2-55 branch April 9, 2026 01:56
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Apr 9, 2026
## Overview

Fix color contrast to pass accessibility tests.

## Related

- caused by TACC/Core-CMS#1089
- requires TACC/Core-CMS#1144
- required by TACC/Core-Portal-Deployments#170

## Changes

- **deletes** ecep-derived neutral colors
    <sup>this makes easier/consistent a11y color contrast testing)</sup>
- **changes** an accent color to pass a11y color contrast
- **adds** footer style to use black bkgd not header color

## Testing

Run [Link Color Contrast
Checker](https://webaim.org/resources/linkcontrastchecker/?fcolor=222222&bcolor=FFFFFF&lcolor=844FCD)
against all combinations of text and background colors.
- https://pprd.ecep.tacc.utexas.edu/publications/ (light and muted
sections)
- https://pprd.ecep.tacc.utexas.edu/resources/models/cmp/ (dark
sections)

Test Accordion (`<details><summary>`) UI states match those of links:
- https://pprd.ecep.tacc.utexas.edu/cs-data/ecep-cs-education-dashboard/

## UI

Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant