fix: a11y issues, round 2

[wesleyboar]

Overview

Fix more accessibility bugs.

Related

• continues fix: a11y issues #1089
• referenced by fix: a11y issues, round 2 tup-ui#546

Changes

• fix: links [not distinguishable enough] on news article leads
  Links in lead are usually only hidden external article links, but we technically can have visible links in article leads.

Testing

Verify colors of link, unlinked text, and body, pass color contrast test.

UI

see.code.in.action.and.relevant.markup.mov

screenshot ofcolor contrast test passing

[qodo-code-review]

Review Summary by Qodo

Remove hardcoded color from news article lead links

🐞 Bug fix

Walkthroughs

Description

• Remove hardcoded link color from news article leads
• Allows links to inherit proper contrast colors
• Fixes accessibility color contrast issues

Diagram

flowchart LR
  A["news-feed-article__lead mixin"] -- "remove hardcoded color" --> B["links inherit proper colors"]
  B -- "ensures" --> C["WCAG color contrast compliance"]

Loading

File Changes

1. taccsite_cms/static/site_cms/css/src/_imports/tools/x-news.css 🐞 Bug fix +0/-1

Remove hardcoded color from article lead styling

• Removed hardcoded color: var(--global-color-primary--dark) from news-feed-article__lead mixin
• Allows links in article leads to inherit appropriate color values
• Improves color contrast accessibility for visible links in article leads

taccsite_cms/static/site_cms/css/src/_imports/tools/x-news.css

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more