Skip to content

refactor: settings_* and secrets into settings/#1075

Merged
wesleyboar merged 9 commits into
stablefrom
fix/core-cms-template-gh-18
Jan 30, 2026
Merged

refactor: settings_* and secrets into settings/#1075
wesleyboar merged 9 commits into
stablefrom
fix/core-cms-template-gh-18

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Jan 28, 2026

Copy link
Copy Markdown
Member

Overview

Move settings files into settings/ directory.

Caution

Clients should not migrate settings yet. Settings will move again.

Related

Changes

  • moved example settings files into settings/
  • updated import paths in settings.py to reflect new structure
  • updated README
  • deprecated old import paths

Testing

Old Path Works - Camino

Tip

Works!

  1. Branch https://github.com/TACC/Texascale-CMS.
  2. Use taccwma/core-cms:fix-core-cms-template-gh-18--v4-36.
  3. Build taccwma/texascale-cms image.
  4. Deploy to pre-prod.
  5. Verify no error & no change (compare to prod).

New Path Works - Camino

Tip

Works!

  1. Open https://github.com/TACC/Core-Portal-Deployments.
  2. For LCCF, use taccwma/core-cms:fix-core-cms-template-gh-18.
  3. Deploy to pre-prod.
  4. Verify no error & no change (compare to prod).

New Path Works - Local

Tip

Works!

Important

  • I tested with logging from 9252749.
  • A.I. tested with temp scripts from ae4ad33.
  1. make clean
  2. make setup
  3. Verify creation of:
    • taccsite_cms/settings/settings_custom.py
    • taccsite_cms/settings/settings_local.py
    • taccsite_cms/settings/secrets.py
  4. make start ARGS=--detach
  5. Open http://localhost:8000/.
  6. Confirm site loads with no import errors.

Old Path Works - Local

Tip

Works!

Important

  • I tested with logging from 9252749.
  • A.I. tested with temp scripts from ae4ad33.
  1. Remove or Rename:
    • taccsite_cms/settings/settings_custom.py
    • taccsite_cms/settings/settings_local.py
    • taccsite_cms/settings/secrets.py
  2. Create root-level files from examples:
    • taccsite_cms/settings_custom.py
    • taccsite_cms/settings_local.py
    • taccsite_cms/secrets.py
  3. make start ARGS=--detach
  4. Open http://localhost:8000/.
  5. Confirm site loads with no import errors.

UI

Skipped.

- Moved settings files into a dedicated `settings` directory.
- Updated import paths in `settings.py` to reflect new structure.
- Added example settings files for `settings_custom`, `settings_local`, and `secrets`.
- Revised README instructions for creating settings files to match new paths.
- Deprecated old import paths with comments for clarity.
@wesleyboar wesleyboar marked this pull request as ready for review January 29, 2026 23:09
@wesleyboar wesleyboar marked this pull request as draft January 30, 2026 21:37
@wesleyboar wesleyboar marked this pull request as ready for review January 30, 2026 22:57
@wesleyboar wesleyboar merged commit cb5effd into stable Jan 30, 2026
@wesleyboar wesleyboar deleted the fix/core-cms-template-gh-18 branch January 30, 2026 23:04
@wesleyboar wesleyboar mentioned this pull request Jan 30, 2026
wesleyboar added a commit that referenced this pull request Jan 30, 2026
## Overview

Merge in
[v4.37.0](https://github.com/TACC/Core-CMS/releases/tag/v4.37.0).

## Changes

- v4.36.23...v4.37.0

## Testing

Already tested via #1075 on Texascale.

---------

Co-authored-by: fnets <fnetscher@gmail.com>
Comment thread bin/setup-cms.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker Compose Can Create Folders In Place of Missing Files

1 participant