Skip to content

fix: social media icons were giant by default#1026

Merged
wesleyboar merged 2 commits into
mainfrom
fix/giant-social-media-icons-by-default
Nov 13, 2025
Merged

fix: social media icons were giant by default#1026
wesleyboar merged 2 commits into
mainfrom
fix/giant-social-media-icons-by-default

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Nov 13, 2025

Copy link
Copy Markdown
Member

Overview

Social media icons need not be giant by default.

I had misconception any size meant a standard I commit to, but I found a simple solution.

Related

Changes

  • added default size for icons (match font-size)
  • fixed extra space within link around svg

Testing

  1. Add snippet with "Template" of share_on_social.html.
  2. Verify SVG size matches font-size by default.
  3. Verify SVG size can be increased with CSS.
  4. Verify link around SVG has no extra space.
    Hover over icon, see no underlined space.

UI

social media icons inherit current font size
no.underlined.space.mov

@wesleyboar wesleyboar changed the title fix: social media icons need not default giant fix: social media icons were giant by default Nov 13, 2025
@wesleyboar wesleyboar merged commit 82cbb84 into main Nov 13, 2025
@wesleyboar wesleyboar deleted the fix/giant-social-media-icons-by-default branch November 13, 2025 22:35
wesleyboar added a commit that referenced this pull request Nov 13, 2025
* fix: social media icons need not default giant

* fix: prevent underline of extra space on hover

by removing extra space
wesleyboar added a commit that referenced this pull request Nov 13, 2025
fix: social media icons were giant by default (#1026)

* fix: social media icons need not default giant

* fix: prevent underline of extra space on hover

by removing extra space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant