Fix EXO connection error handling for MSAL auth failures#300
Open
T0pCyber wants to merge 1 commit intoDevelopmentfrom
Open
Fix EXO connection error handling for MSAL auth failures#300T0pCyber wants to merge 1 commit intoDevelopmentfrom
T0pCyber wants to merge 1 commit intoDevelopmentfrom
Conversation
Test-EXOConnection previously only caught CommandNotFoundException, missing MSAL token acquisition errors (MsalServiceException) and stale/expired session failures. This caused unhandled crashes when Hawk auto-connected to Exchange Online (issue #287). Changes: - Catch all exceptions from Get-OrganizationConfig, not just CommandNotFoundException, to handle expired sessions - Wrap Connect-ExchangeOnline with error handling and a single retry for transient MSAL errors - Provide a clear error message with manual workaround if both connection attempts fail Closes #287 https://claude.ai/code/session_01BnFujty83uF1tyubTjtmx4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-EXOConnectionto catch all exceptions fromGet-OrganizationConfig, not justCommandNotFoundException— this handles expired/stale sessions that previously fell through silentlyConnect-ExchangeOnlinewith error handling and a single retry for transient MSAL token acquisition errors (MsalServiceException)Problem
Users reported unhandled
MsalServiceExceptioncrashes when Hawk auto-connected to Exchange Online (see #287). The root cause was thatTest-EXOConnectiononly caughtCommandNotFoundException, leaving MSAL authentication errors and stale session failures completely unhandled.Test plan
Closes #287
https://claude.ai/code/session_01BnFujty83uF1tyubTjtmx4