Bugfix/210 bugip stack api key flow needs improvement for better user experience new#243
Open
dcodev1702 wants to merge 56 commits intoDevelopmentfrom
Conversation
added 9 commits
January 18, 2025 15:26
…to check and test IPSTACK API keys.
…ser output. GeoIP Location working well.
jonnybottles
requested changes
Jan 20, 2025
…or-better-user-experience-new' of https://github.com/T0pCyber/hawk into bugfix/210-bugip-stack-api-key-flow-needs-improvement-for-better-user-experience-new
…nteractive modes where an API Key (IPSTACK) does not exist and is provided.
…f EnableGeoIPLocation
… keys are working. User is now being prompted to save API KEY. Need to return when the correct key is entered and saved to disk or not
… keys are working. User is now being prompted to save API KEY. Need to return when the correct key is entered and saved to disk or not
…s still good but will NOT prompt the user the option to save it to disk. We will detect bad keys, malformed keys, and if an access key is provided from the user, they will be prompted the option to save the key to disk with the proper warning at the API key is currently stored in plaintext.
Sntai20
reviewed
Feb 23, 2025
added 30 commits
February 24, 2025 02:41
… in Get-IPStackAPIKey :: Line 42-65
…n file on disk [Add-HawkData].
…h to execute from. if(Read-HawkAppData) was not working as intended.
…rompted for a new key.
…back invalid, user prompted to enter new key and enters in an empty space and presses enter. INPUT-VALIDATION.
… w/o a valid REST API Access Key from ipstack.com
…rmine code flow between interactive and non-interactive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: