Skip to content

fix: address review findings across app, tests, and CI (#29)#30

Merged
Synertry merged 1 commit into
releasefrom
main
Jun 14, 2026
Merged

fix: address review findings across app, tests, and CI (#29)#30
Synertry merged 1 commit into
releasefrom
main

Conversation

@Synertry

Copy link
Copy Markdown
Owner

Resolve the actionable items from the multi-agent review. Closes the script-injection vectors in review-approval, stops SaveAsync from discarding data on a failed move, marshals scrape progress to the UI thread, locks the timestamp reads, and adds RefreshService plus view-model tests. CI permission tightenings and the verified false positives were intentionally left out.

Signed-off-by: Synertry 60792595+Synertry@users.noreply.github.com

Resolve the actionable items from the multi-agent review. Closes the script-injection vectors in review-approval, stops SaveAsync from discarding data on a failed move, marshals scrape progress to the UI thread, locks the timestamp reads, and adds RefreshService plus view-model tests. CI permission tightenings and the verified false positives were intentionally left out.

Signed-off-by: Synertry <60792595+Synertry@users.noreply.github.com>
@Synertry Synertry added the workflow/auto-pr Pull request opened by an automated workflow label Jun 14, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

Copy link
Copy Markdown

Release Candidate Summary

Automation report for review before merging into release.

Statistics

  • Commits: 1
  • Files Changed: 17

Changed Files

Click to expand file list
M	.github/labels.yaml
M	.github/workflows/branch-delete.yaml
M	.github/workflows/pre-release-review.yaml
M	.github/workflows/release.yaml
M	.github/workflows/review-approval.yaml
M	.github/workflows/stale-triage.yaml
M	.github/workflows/test.yaml
A	OpenTDBLookup.Tests/MainWindowViewModelTests.cs
A	OpenTDBLookup.Tests/RefreshServiceTests.cs
M	OpenTDBLookup/App.axaml.cs
M	OpenTDBLookup/Services/IClipboardWatcher.cs
M	OpenTDBLookup/Services/QuestionRepository.cs
M	OpenTDBLookup/Services/SettingsService.cs
M	OpenTDBLookup/Services/ToastService.cs
M	OpenTDBLookup/ViewModels/MainWindowViewModel.cs
A	OpenTDBLookup/ViewModels/MainWindowViewModelDesignStubs.cs
M	OpenTDBLookup/ViewModels/ScrapeProgressViewModel.cs

Commit History

Click to expand commit log

Generated by GitHub Actions for Release Verification

@github-actions github-actions Bot added status/review-needed Requires human review before merging status/approval-pending Waiting on approver before fast-forward to release area/CI GitHub workflows, Dependabot, labelers, scripts area/source C# source code (non-test) area/ui Avalonia XAML markup and code-behind area/tests Tests under OpenTDBLookup.Tests/ size/l Large diff (< 2500 lines, 50 files) and removed status/review-needed Requires human review before merging status/approval-pending Waiting on approver before fast-forward to release labels Jun 14, 2026
@Synertry

Copy link
Copy Markdown
Owner Author

/approve

@Synertry Synertry merged commit 7cd6f4d into release Jun 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI GitHub workflows, Dependabot, labelers, scripts area/source C# source code (non-test) area/tests Tests under OpenTDBLookup.Tests/ area/ui Avalonia XAML markup and code-behind size/l Large diff (< 2500 lines, 50 files) status/review-needed Requires human review before merging workflow/auto-pr Pull request opened by an automated workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants