Issue #239 #243
Open
Issue #239 #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…global Instance being set.
opalczynski
reviewed
Sep 15, 2016
syncano/models/manager.py
Outdated
| def _populate_instance_name(self, object): | ||
| if 'instance_name' not in self.properties or not isinstance(object, dict): | ||
| return | ||
| model_fields = ['profile'] |
Contributor
There was a problem hiding this comment.
This line will force us to extend it each time when new ModelField is defined.
Contributor
There was a problem hiding this comment.
Beside that - I've checked this solution and it seems that it's not working.
Contributor
Author
There was a problem hiding this comment.
It works for me. Will refactor and provide test case :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.