Polish sonar-vision to production grade + realistic simulation scenarios#1
Merged
Conversation
- Fix GitHub repo description to match actual toolkit scope. - Add MIT LICENSE file and license metadata in pyproject.toml. - Update README/API_REFERENCE/GETTING_STARTED/ARCHITECTURE/LOW_LEVEL/PLUG_AND_PLAY to reflect the real public API and remove non-existent methods. - Export Detection, Track, Obstacle, CellState, PingResult from sonar_vision. - Make Sonar.ping parameter name match README (distance) and correct active sonar to use two-way transmission loss. - Add tests/test_simulation_scenarios.py: realistic multi-target underwater scene exercising Sonar -> ObjectTracker -> SpatialMap pipeline. - Add SIMULATION_TEST_REPORT.md documenting scenario, findings, and gaps. Local pytest is unavailable; full suite was verified with a temporary shim and will be confirmed by GitHub Actions CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR polishes the repo to match its actual scope and adds realistic end-to-end simulation tests.
Changes:
Local pytest is unavailable; verification is delegated to CI.