This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Conversation
jaimeiniesta
reviewed
Dec 3, 2019
Contributor
There was a problem hiding this comment.
I think we can get rid of this else, because the default behavior of a with clause is returning what doesn't match. Unless we're doing a special treatment of the error, logging it, etc., we don't need the else.
jaimeiniesta
approved these changes
Dec 3, 2019
Contributor
jaimeiniesta
left a comment
There was a problem hiding this comment.
LGTM! I think the only case where we want to handle a non-JSON response is already handled for the 204 status code above. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stuart-team.atlassian.net/browse/INT-9
We've identified that when making http request calls and there is a 500 error for instance the function
to_api_responsealways tries to parse the json which ends up raising anJason.DecodeErrorexception.With this change we return the tuple error instead. We will adapt monocle code afterwards to adapt it to this change.