Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/stuart_client_elixir/http_client.ex
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ defmodule StuartClientElixir.HttpClient do
]
end

defp to_api_response({:ok, %HTTPoison.Response{status_code: 204}}) do
%{status_code: 204, body: ""}
end

defp to_api_response({:ok, %HTTPoison.Response{status_code: status_code, body: body}}) do
%{status_code: status_code, body: Jason.decode!(body)}
end
Expand Down
23 changes: 23 additions & 0 deletions test/stuart_client_elixir/http_client_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,39 @@ defmodule StuartClientElixirTest.HttpClientTest do
end
end

describe "handles 204 no content response" do
@expected_no_content_response %{status_code: 204, body: ""}

test "204 no content in GET" do
assert HttpClient.get("/no_content", config()) == @expected_no_content_response
end

test "204 no content in POST" do
assert HttpClient.post("/no_content", sample_request_body(), config()) ==
@expected_no_content_response
end

test "204 no content in PATCH" do
assert HttpClient.patch("/no_content", sample_request_body(), config()) ==
@expected_no_content_response
end
end

#####################
# Private functions #
#####################

@timeout_url "https://sandbox-api.stuart.com/timeout"
@no_content_url "https://sandbox-api.stuart.com/no_content"

defp response(_, @timeout_url) do
{:error, %HTTPoison.Error{id: nil, reason: :timeout}}
end

defp response(_, @no_content_url) do
{:ok, %HTTPoison.Response{status_code: 204, body: ""}}
end

defp response(:get, _) do
{:ok, %HTTPoison.Response{status_code: 200, body: Jason.encode!(%{sample: "get response"})}}
end
Expand Down