STR-357 :: If fingerprint analytics fails, continue anyways#99
Merged
STR-357 :: If fingerprint analytics fails, continue anyways#99
Conversation
b80ba2f to
af68d22
Compare
afcc43d to
84d4a15
Compare
ocasta181
previously approved these changes
Jan 31, 2023
saito-sv
reviewed
Jan 31, 2023
saito-sv
reviewed
Jan 31, 2023
auroter
approved these changes
Jan 31, 2023
Contributor
auroter
left a comment
There was a problem hiding this comment.
I left some optional suggestions. If you decide to commit them, let me know and I'll re-approve.
| return Unprocessable(c) | ||
| } | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "unknown device") { |
Contributor
There was a problem hiding this comment.
This way of checking the error is fine, but we can also check the top level error like so:
Suggested change
| if strings.Contains(err.Error(), "unknown device") { | |
| if err != nil && errors.Cause(err).Error() == "unknown device" { |
Which you can see on api/handler/quotes.go:41
| if strings.Contains(err.Error(), "unknown device") { | ||
| return Unprocessable(c) | ||
| } | ||
| if strings.Contains(err.Error(), "invalid email") { |
Contributor
There was a problem hiding this comment.
Same idea here as above. You could also say:
Suggested change
| if strings.Contains(err.Error(), "invalid email") { | |
| if errors.Cause(err).Error() == "invalid email" { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test:
fix/wil/str-357docker-compose up redis db string-api --buildVITE_ANALYTICS_LIB_PK=123