Added SanitizeChecksums to handler package, and similar SanitizeCheck…#81
Merged
Added SanitizeChecksums to handler package, and similar SanitizeCheck…#81
Conversation
added 2 commits
January 10, 2023 17:13
ocasta181
reviewed
Jan 11, 2023
api/handler/transact.go
Outdated
Comment on lines
+32
to
+38
| SanitizeChecksums(&body.CxAddr, &body.UserAddress) | ||
| // Sanitize Checksum for body.CxParams? It might look like this: | ||
| var cxParams []*string | ||
| for _, p := range body.CxParams { | ||
| cxParams = append(cxParams, &p) | ||
| } | ||
| SanitizeChecksums(cxParams...) |
Contributor
There was a problem hiding this comment.
Although it looks like we're trying to sanitize body params here... We're definitely failing at this rn.
ocasta181
approved these changes
Jan 11, 2023
frostbournesb
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
Additionally, we can test the other places which take in addresses such as creating a user or executing a transaction.