Conversation
saito-sv
commented
Jul 21, 2023
auroter
suggested changes
Jul 23, 2023
Contributor
auroter
left a comment
There was a problem hiding this comment.
All of the tests passed except for one:
=== RUN TestIntegrationCreateInquiry
persona_integration_test.go:50:
Error Trace: /Users/sean/dev/string/string-api/pkg/internal/persona/persona_integration_test.go:50
Error: Received unexpected error:
request failed with status code: 404
github.com/String-xyz/go-lib/v2/common.StringError
/Users/sean/go/pkg/mod/github.com/!string-xyz/go-lib/v2@v2.0.3/common/error.go:64
github.com/String-xyz/string-api/pkg/internal/persona.(*PersonaClient).CreateInquiry
/Users/sean/dev/string/string-api/pkg/internal/persona/inquiries.go:55
github.com/String-xyz/string-api/pkg/internal/persona.TestIntegrationCreateInquiry
/Users/sean/dev/string/string-api/pkg/internal/persona/persona_integration_test.go:49
testing.tRunner
/usr/local/go/src/testing/testing.go:1446
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1594
failed to create inquiry
github.com/String-xyz/go-lib/v2/common.StringError
/Users/sean/go/pkg/mod/github.com/!string-xyz/go-lib/v2@v2.0.3/common/error.go:64
github.com/String-xyz/string-api/pkg/internal/persona.(*PersonaClient).CreateInquiry
/Users/sean/dev/string/string-api/pkg/internal/persona/inquiries.go:55
github.com/String-xyz/string-api/pkg/internal/persona.TestIntegrationCreateInquiry
/Users/sean/dev/string/string-api/pkg/internal/persona/persona_integration_test.go:49
testing.tRunner
/usr/local/go/src/testing/testing.go:1446
runtime.goexit
/usr/local/go/src/runtime/asm_amd64.s:1594
Test: TestIntegrationCreateInquiry
persona_integration_test.go:51:
Error Trace: /Users/sean/dev/string/string-api/pkg/internal/persona/persona_integration_test.go:51
Error: Expected value not to be nil.
Test: TestIntegrationCreateInquiry
--- FAIL: TestIntegrationCreateInquiry (0.21s)
ocasta181
approved these changes
Jul 25, 2023
ocasta181
reviewed
Jul 25, 2023
ocasta181
reviewed
Jul 25, 2023
Comment on lines
+18
to
+22
| return &PersonaClient{ | ||
| APIKey: apiKey, | ||
| BaseURL: "https://withpersona.com/api/", | ||
| Client: &http.Client{}, | ||
| } |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| return &PersonaClient{ | |
| APIKey: apiKey, | |
| BaseURL: "https://withpersona.com/api/", | |
| Client: &http.Client{}, | |
| } | |
| return NewPersonaClient("https://withpersona.com/api/", apiKey, &http.Client{}) |
ocasta181
reviewed
Jul 25, 2023
| Check for the following statuses to determine whether the individual has finished the flow. | ||
|
|
||
| * Created - The individual started the inquiry. | ||
| * Pending - The individual submitted a verification within the inquiry. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Pending - The individual submitted a verification within the inquiry. | |
| * Pending - The individual submitted one or more verifications within the inquiry. |
auroter
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persona API Wrapper
This PR includes the bare minimum persona integration (accounts, inquiries and verifications)
Setup
Make sure to have a
PERSONA_API_KEYin your.envfile. You can use this onepersona_sandbox_a12e2d79-11f0-4470-b596-16d6e682123aTests
go test ./pkg/internal/persona/ -vgo test -tags=integration ./pkg/internal/persona/ -v