Skip to content

Get destination_leg asset based on chain#117

Merged
ocasta181 merged 1 commit intodevelopfrom
task/andrin/str-400
Feb 13, 2023
Merged

Get destination_leg asset based on chain#117
ocasta181 merged 1 commit intodevelopfrom
task/andrin/str-400

Conversation

@ocasta181
Copy link
Copy Markdown
Contributor

@ocasta181 ocasta181 commented Feb 13, 2023 •
edited
Loading

  1. Run a transaction on avalanche
  2. Ensure that the destination_leg asset (AVAX) is properly reflected in the database and unit21
  3. Run a transaction on another network
  4. Ensure that the destination_leg asset is properly reflected in the db and unit21

@ocasta181 ocasta181 changed the title rename to match style guide; get asset based on chain Get destination_leg asset based on chain Feb 13, 2023
@ocasta181 ocasta181 marked this pull request as ready for review February 13, 2023 22:19
auroter
auroter approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me! Displayed AVAX Asset ID on AVAX and MATIC on MATIC:

image

saito-sv
saito-sv approved these changes Feb 13, 2023
View reviewed changes
Copy link
Copy Markdown

@saito-sv saito-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocasta181 ocasta181 merged commit 3c7990b into develop Feb 13, 2023
@ocasta181 ocasta181 deleted the task/andrin/str-400 branch February 13, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alcalawil alcalawil Awaiting requested review from alcalawil

@frostbournesb frostbournesb Awaiting requested review from frostbournesb

2 more reviewers

@auroter auroter auroter approved these changes

@saito-sv saito-sv saito-sv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocasta181 @auroter @saito-sv