Skip to content

fix(microphone): stop hold-to-talk ping ring from stealing clicks - #80

Merged
Roboroads merged 1 commit into
mainfrom
fix/mic-ping-pointer-events
Jul 2, 2026
Merged

fix(microphone): stop hold-to-talk ping ring from stealing clicks#80
Roboroads merged 1 commit into
mainfrom
fix/mic-ping-pointer-events

Conversation

@Roboroads

@Roboroads Roboroads commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Adds pointer-events-none to the pulsing ring span so its animate-ping-expanded hit area no longer intercepts clicks meant for controls above the hold-to-talk button.

Fixes #70

Summary by CodeRabbit

  • Bug Fixes
    • Improved the hold-to-talk microphone button so the live “ping” indicator no longer blocks pointer interactions.

Signed-off-by: Robbin "Roboroads" Schepers <robbin@deschepers.nl>
@Roboroads
Roboroads marked this pull request as ready for review July 2, 2026 10:31
@Roboroads
Roboroads enabled auto-merge (squash) July 2, 2026 10:31
@Roboroads
Roboroads disabled auto-merge July 2, 2026 10:33
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 24627d33-a156-45e8-aaab-2643f6af261a

📥 Commits

Reviewing files that changed from the base of the PR and between 2966695 and af0d084.

📒 Files selected for processing (1)
  • packages/streamline/renderer/src/modules/microphone/Microphone.svelte

📝 Walkthrough

Walkthrough

The ping overlay span shown when the microphone is live inside the hold-to-talk button was updated to add the pointer-events-none class and reformatted across multiple lines, preventing it from intercepting pointer clicks.

Changes

Ping overlay pointer-events fix

Layer / File(s) Summary
Prevent ping overlay from stealing clicks
packages/streamline/renderer/src/modules/microphone/Microphone.svelte
The live-only ping overlay span now includes pointer-events-none and is reflowed into multi-line markup so it no longer intercepts clicks on controls above the hold-to-talk button.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related Issues

Fixes: #70

Suggested labels: bug, ui

Suggested reviewers: N/A

Poem
A rabbit hopped near a pulsing red ring,
It clicked and it clacked—the wrong button would sing.
Now pointer-events-none keeps the ping in its place,
No more stolen clicks, no more mic in your face.
Hop, hop, hooray for a fix clean and small! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: preventing the mic pulse ring from intercepting clicks.
Linked Issues check ✅ Passed The change adds pointer-events-none to the live pulse ring, which directly matches issue #70's suggested fix.
Out of Scope Changes check ✅ Passed The diff is limited to the microphone pulse ring behavior and a formatting change, with no unrelated scope added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Roboroads
Roboroads merged commit b1e1510 into main Jul 2, 2026
13 checks passed
@Roboroads
Roboroads deleted the fix/mic-ping-pointer-events branch July 2, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microphone: hold-to-talk pulse overlaps buttons above and steals their clicks

1 participant