Rebasing from main branch #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test.ps1` is invoked by `test.sh` and it does install the module already, so no need to install the module again. This commit removes the second installation attempt. Signed-off-by: Suraj Deshmukh <[email protected]>
Format the script to remove all the trailing whitespaces. Signed-off-by: Suraj Deshmukh <[email protected]>
`tests/PSinLinuxCloudShellImage.Tests.ps1` expects the powershell version to be `'7.4*'` so change it to `'7.5*'`. Signed-off-by: Suraj Deshmukh <[email protected]>
Format the script to remove all the trailing whitespaces. Signed-off-by: Suraj Deshmukh <[email protected]>
libmi.so was earlier downloaded from a Azure blob store. This commit adds the file to the repo and the file is added to the docker image using an COPY command. Signed-off-by: Suraj Deshmukh <[email protected]>
Remove the dependency on the blob store: pscloudshellbuild.blob.core.windows.net Signed-off-by: Suraj Deshmukh <[email protected]>
Remove dependency on blob storage
This commit updates the installation steps to install only Istio and not the entire Istio Github package. Signed-off-by: Suraj Deshmukh <[email protected]>
base-istio: Only install istioctl binary
The URL that returns the terraform version has started prefixing `v` for the
version number in the field: `current_version`.
```json
{"product":"terraform","current_version":"v1.11.0",
"current_release":1740666694,
"current_download_url":"https://releases.hashicorp.com/terraform/1.11.0",
"current_changelog_url":"https://github.com/hashicorp/terraform/blob/v1.11.0/CHANGELOG.md",
"project_website":"https://www.terraform.io","alerts":[]}
```
This extra `v` generates erroneous link and thus when we try to download we get
a 404. For example the link becomes:
```
https://releases.hashicorp.com/terraform/v1.11.0/terraform_v1.11.0_linux_amd64.zip
```
Instead of:
```
https://releases.hashicorp.com/terraform/1.11.0/terraform_1.11.0_linux_amd64.zip
```
This commit removes that extra `v` to download the correct build of terraform.
Signed-off-by: Suraj Deshmukh <[email protected]>
base: Fix the terraform version
…ttps://github.com/Azure/CloudShell into priyaananthasankar/base_image_tag_update_02272024
This reverts commit 19b5288.
…update_02272024 Added new base image tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing from main branch