Skip to content

Added SMODS.can_context_retrigger() and SMODS.can_context_post_trigger() util functions#1391

Open
AllUniversal wants to merge 6 commits into
Steamodded:mainfrom
AllUniversal:context-retrigger-check-utils
Open

Added SMODS.can_context_retrigger() and SMODS.can_context_post_trigger() util functions#1391
AllUniversal wants to merge 6 commits into
Steamodded:mainfrom
AllUniversal:context-retrigger-check-utils

Conversation

@AllUniversal
Copy link
Copy Markdown
Contributor

@AllUniversal AllUniversal commented May 18, 2026

+Title, these replace the hardcoded context flag checks and newly (fully) prevent context.mod_probability/etc. from being retriggered/post_triggered.

! I'm not sure how SMODS.calculate_repetitions() works exactly, maybe someone take a look whether it needs to be adjusted as well.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

…gger()`

+Title, they replace the hardcoded context flag checks.
@AllUniversal
Copy link
Copy Markdown
Contributor Author

I've had a discussion about whether certain contexts should be post_triggerable, and though I can see the use in it, it seems to inevitably lead to problems which SMODS cannot easily (or at all) resolve on its end. Thus I've added some more contexts to the post_trigger/retrigger blacklist for now, specifically modify_weights, modify_scoring_hand and evaluate_poker_hand. Please let me know if an effect of yours requires these to be post-/retriggerable.

@nh6574
Copy link
Copy Markdown
Member

nh6574 commented Jun 1, 2026

debuff_hand should probably also be included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants