Skip to content

Conversation

@cognifloyd
Copy link
Member

Background

This is another part of introducing pants, as discussed in various TSC meetings.

Related PRs can be found in:

Overview of this PR

This is a follow-up for #5842 which configured pants to find plugins in pants-plugins/.

This PR consists of 4 updates:

  • Now that I'm writing tests, I need to enable installing the pants testutils.
  • Finish configuring interpreter_constraints for pants-plugins/. I didn't realize that we had to configure this in both pants.toml (which I did in Configure pants to look for plugins in pants-plugins/ directory #5842) and in pants-plugins/BUILD (which this PR adds).
  • The pants-plugins code does not support python3.6. Once I started adding code under pants-plugins, the compileall Makefile target fails under python 3.6. So, I just exclude pants-plugins/ from that step in the Makefile.
  • The tools' lockfiles, and the pants-plugins lockfile needed to be regenerated to account for the additional interpreter_constraints and the new testutils dep.

You can review each commit separately to see each of these items (lockfile regeneration is included in the commit that triggered the changes).

@cognifloyd cognifloyd added this to the pants milestone Dec 18, 2022
@cognifloyd cognifloyd self-assigned this Dec 18, 2022
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Dec 18, 2022
@cognifloyd cognifloyd enabled auto-merge December 19, 2022 20:33
@cognifloyd cognifloyd requested a review from a team December 19, 2022 20:44
@cognifloyd cognifloyd merged commit f60dfb8 into master Dec 29, 2022
@cognifloyd cognifloyd deleted the pants-plugins-prep branch December 29, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external dependency infrastructure: ci/cd pantsbuild size/L PR that changes 100-499 lines. Requires some effort to review. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants