pin typing-extensions<4.2 to fix st2client install #5638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9800b94 to
d5e0610
Compare
st2client requires importlib-metadata which requires typing-extensions. But typing-extensions v4.2.0 dropped support for python3.6, so pin it.
d5e0610 to
5607dd8
Compare
nzlosh
approved these changes
May 4, 2022
arm4b
approved these changes
May 4, 2022
Contributor
|
Do we still need to support Python 3.6? This is mainly an issue with st2sensorcontainer. Many of our sensors use pydantic which has dropped support for typing-extensions<4.2. |
Contributor
|
Yes at the moment. It's still needed for Ubuntu 18.04 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
st2client requires importlib-metadata which requires typing-extensions.
But typing-extensions v4.2.0 dropped support for python3.6, so pin it.
Our CI has been broken on st2 master since April 17: https://github.com/StackStorm/st2/actions/workflows/ci.yaml?page=2
Turns out it’s because of typing-extensions which dropped support for python 3.6 on April 17 with their 4.2.0 release: https://github.com/python/typing/blob/master/typing_extensions/CHANGELOG.md