Fixes Python Logging API Change #4923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging module added a stacklevel=1 kwarg in python3.8 We need to do the same since we override that method.
|
|
Contributor
Author
|
This fixes this issue: #4922 |
blag
previously requested changes
Apr 27, 2020
Contributor
blag
left a comment
There was a problem hiding this comment.
If the stacklevel parameter isn't actually used anywhere, it would probably be better to use **kwargs to capture it.
Contributor
Author
|
Updated, but I had to use |
nmaludy
suggested changes
Sep 29, 2020
Member
nmaludy
left a comment
There was a problem hiding this comment.
Can you please add a CHANGELOG entry for this?
nmaludy
approved these changes
Oct 1, 2020
arm4b
reviewed
Oct 2, 2020
Co-authored-by: Eugen C. <[email protected]>
Requested changes were addressed by the PR author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging module added a stacklevel=1 kwarg in python3.8 to the findCaller() function
We need to do the same since we override that method.
Closes #4922