Fix for #19 to fix JSON values in --extra-vars#20
Merged
arm4b merged 2 commits intoSep 12, 2017
Conversation
cognifloyd
approved these changes
Sep 12, 2017
cognifloyd
left a comment
Member
There was a problem hiding this comment.
That's exactly how i would fix this: 8c2d845
Member
|
Thanks @nmaludy for catching & fixing it and @cognifloyd for the review! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
This is a fix for #19 where handling of JSON values in
--extra-varswas not working properly for me.Please give @cognifloyd some time to review the issue before merging.