fix verify crash caused by invalid cert format#60
Merged
yorkie merged 4 commits intoSouthern:masterfrom Nov 28, 2017
Merged
Conversation
Collaborator
|
Hi @lolBig I have fixed the verification expiration issue at #62, and may I ask you to add some tests for your patch? |
added 2 commits
November 28, 2017 21:59
* upstream/master: test: update cert & chain for verify (Southern#62)
yorkie
reviewed
Nov 28, 2017
test/test.js
Outdated
| path.join(__dirname, 'certs/equifax.crt'), | ||
| path.join(__dirname, '/test.js'), | ||
| function(err, result) { | ||
| assert.notStrictEqual(err, null); |
Collaborator
There was a problem hiding this comment.
Should throw an invalid format error here?
Contributor
Author
There was a problem hiding this comment.
error was caught by function verify
Collaborator
|
Rad! LGTM if CI is green @lolBig :) |
Collaborator
|
Merged and published at v0.3.3 :) /cc @Southern |
Owner
|
Why is there a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function verify should return after call Nan::ThrowError, otherwise point memory will be free multi times, and then crash the main thread.