Cache milagro g1 pubkeys

[yrong]

for SNO-356 and PRs accompanied
Snowfork/incubator-milagro-crypto-rust#2
Snowfork/milagro_bls#2
Snowfork/cumulus#19

[yrong]

Benchmark

https://github.com/Snowfork/cumulus/pull/19/files#diff-db08d74f3fe259c221df3ac86f73c1e06ebafc90e2907e95b98ff9cf71018ced

• execution time decreased by almost 4 times less than before as following.

Extrinsic	Minimum Execution Time before optimization(us)	Minimum Execution Time after optimization(us)
sync_committee_period_update	125_394	138_632
import_finalized_header	119_688	30_960
import_execution_header	119_457	30_946

• storage proof size increased by almost 3 times more than before as following.

Extrinsic	Storage Proof Size Estimated before optimization(bytes)	Storage Proof Size Estimated after optimization(bytes)
sync_committee_period_update	72217	207289
import_finalized_header	43615	111151
import_execution_header	37729	105265

[doubledup]

Looks good! Going through the companion PRs now

[yrong]

In recent commit I've added the optimization about substract absent G1 points as discussed before, benchmark here shows only a minor improvement achieved.

Benchmark also shows that the milagro fast_aggregate_verify_pre_aggregated consumes almost all of the weight(>90%) so is the major bottleneck now.

[vgeddes]

@vgeddes In recent commit I've added the optimization about substract absent G1 points as we discussed before, benchmark here shows only a minor improvement achieved(kind of unexpected). Seems not a key point and I'll double check.

Ah, too bad. Let's keep the optimization though. It does shave off some
Weight. 👍

[vgeddes]

Looks better. Though I see you are returning Error instead of DispatchError from utility functions, which is unusual.

Is there a reason for this style?

No special, just change to DispatchError as suggest

[yrong]

@doubledup For this PR to work we need to upgrade rust toolchain to nightly-2023-04-22, I would suspect Nix setup will just respect config here and no special handling required, but correct me if I'm wrong.

[yrong]

@vgeddes The only issue left is we need to add --release for unit test or it will just failed, CI changed here accordingly. I would assume still related to rust compiler and not a block issue.

[vgeddes]

@doubledup For this PR to work we need to upgrade rust toolchain to nightly-2023-04-22, I would suspect Nix setup will just respect config here and no special handling required, but correct me if I'm wrong.

Nope, I tried this, and we first need to update the rust-overlay input package for our Nix env:

nix flake lock --update-input rust-overlay

cc @doubledup

[vgeddes]

OK, approved! lets finally merge this in. First run this though to get the newer rust working:

nix flake lock --update-input rust-overlay