Better Arduino compatibility: Changed the order of Wire.begin and … - #1193
Merged
Conversation
…Wire.pins parameters to match the [Arduino order](samples/DS3232RTC_NTP_Setter/app/application.cpp). Related to SmingHub#1179 and SmingHub#1061. Warning: this is a backward incompatible change.
Contributor
Author
|
@avr39-ripe @max-weller @zgoda Can you check if this PR is working for you as expected? If you have Linux/MacOS the steps to do this are: And then compile and test your favourite sample using |
Contributor
|
Hello! Will try ASAP... ENOTIME just by now :( sorry..
2017-07-18 11:47 GMT+03:00 slaff <notifications@github.com>:
… @avr39-ripe <https://github.com/avr39-ripe> @max-weller
<https://github.com/max-weller> @zgoda <https://github.com/zgoda> Can you
check if this PR is working for you as expected? If you have Linux/MacOS
the steps to do this are:
cd $SMING_HOME
git stash
git fetch origin pull/1193/head:arduino-wire
git checkout arduino-wire
make dist-clean
make
And then compile and test your favourite sample using Wire.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1193 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF6_DLSx1LIgtBrk7XGbOkHG0TQq1iunks5sPHEzgaJpZM4ObBgd>
.
|
|
Hi, thanks for changing this, works great! |
johndoe8967
added a commit
to johndoe8967/Sming
that referenced
this pull request
Aug 5, 2017
* commit '855933d10fe88fee52399930f80fa0362c2180a5': Added WifiStation.connect() to Basic_rboot sample (SmingHub#1215) Appvoyer CI will use the updated choco packages. (SmingHub#1210) Added dynamic recalculation of image offsets to prever rom overlapping. (SmingHub#1208) Added Gitter Notifications. (SmingHub#1205) Better Arduino compatability: Changed to order of the Wire.begin and Wire.pins parameters to (SmingHub#1193) Small fixes before the final 3.3.0 (SmingHub#1203) Preparation for the final 3.3.0 release. (SmingHub#1202) Added example demonstrating Js and CSS combining ... (SmingHub#1200) Fixed WebSocket sample HTML page (SmingHub#1201) Feature/auto deployment on release (SmingHub#1198)
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Nov 6, 2017
…ith Arduino. - Arduino compatibility improvements (SmingHub#1213). - Library code for some Arduino libraries comes directly from their source repositories (Adafruit_ST7735, Adafruit_SSD1306). - Added dynamic recalculation of image offsets to prevent rom overlapping (SmingHub#1208). - Added Wi-Fi Protected Setup (WPS) support (SmingHub#1199). - Ram savings in axTLS (SmingHub#1255). - Simplified and improved Http Client and Http Server stream handling (SmingHub#1247). - Fixed Memory Leak in Mqtt (SmingHub#1273). - Updated Spiffs code to version 0.3.7 + fixes (#SmingHub#1246). And much more. All merged PRs in this release can be seen from [here](https://github.com/SmingHub/Sming/milestone/12?closed=1) - Changed the order of Wire.begin and Wire.pins parameters to match the Arduino order (SmingHub#1193). For a complete list of changes run the following command: ``` git log 3.3.0..3.4.0 ``` Thanks to everyone who helped us make this release happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Wire.pins parameters to match the Arduino order.
Related to #1179 and #1061.
Warning: this is a backward incompatible change.