Handle incomplete frame to prevent WebsocketClient ending in an endle… - #1189
Merged
slaff merged 1 commit intoJul 21, 2017
Conversation
Contributor
|
@avr39-ripe Can you look at that PR too? |
johndoe8967
added a commit
to johndoe8967/Sming
that referenced
this pull request
Jul 21, 2017
* commit 'f4c2d01834a49b10ae0d374d7feeeab38f197d95': Handle incomplete frame to prevent WebsocketClient ending in an endless loop (SmingHub#1189) Fixes for styling issues reported by Codacy (SmingHub#1196) Feature/httpserver etag caching (SmingHub#1194) HttpServer tuning to allow serving of more requests. (SmingHub#1187) decode-stacktrace.py: Added python3 compatability. (SmingHub#1190) Release Candidate 1 for version 3.3.0. (SmingHub#1185) Station::waitConnection method was deprecated and is now removed. (SmingHub#1171) Adding fixes for issues reported by Vera++ and CppCheck. (SmingHub#1178) Changes related to POST parameter unescaping. (SmingHub#1177)
johndoe8967
added a commit
to johndoe8967/Sming
that referenced
this pull request
Jul 28, 2017
* commit '93340e19a1e1e68885a36976113bc400eb2be985': (35 commits) Preparation for the final 3.3.0 release. (SmingHub#1202) Small fixes before the final 3.3.0 (SmingHub#1203) Updated the third-party modules. Added example demonstrating Js and CSS combining ... (SmingHub#1200) Fixed WebSocket sample HTML page (SmingHub#1201) Feature/auto deployment on release (SmingHub#1198) Handle incomplete frame to prevent WebsocketClient ending in an endless loop (SmingHub#1189) Fixes for styling issues reported by Codacy (SmingHub#1196) Feature/httpserver etag caching (SmingHub#1194) HttpServer tuning to allow serving of more requests. (SmingHub#1187) decode-stacktrace.py: Added python3 compatability. (SmingHub#1190) Release Candidate 1 for version 3.3.0. (SmingHub#1185) Station::waitConnection method was deprecated and is now removed. (SmingHub#1171) Adding fixes for issues reported by Vera++ and CppCheck. (SmingHub#1178) Changes related to POST parameter unescaping. (SmingHub#1177) Small fixes to comparison and memory related issues. (SmingHub#1172) Reset response and request data after completion. Custom PWM is enabled by default. (SmingHub#1164) TemplateStream: the total length should be calculated from the browser. HttpServer: The default keepalive time is set to 0. HttpClient: memory usage fixes. (SmingHub#1161) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ss loop
When a WebsocketClient receives an incomplete frame it hangs in an endless loop until the watchdog resets the system.
Marking the frame as incomplete and returning false resolves this issue.
But the data received with this frame is lost. I will create another pull-request for temoprary saving the data and combining them with the next frame(s) for correct evaluation