Skip to content

[NO JIRA]: Add missing babel dep to remove missing warning#187

Merged
Alex Sannikov (xalechez) merged 1 commit into
mainfrom
no-jira-update-dev-deps
Apr 4, 2024
Merged

[NO JIRA]: Add missing babel dep to remove missing warning#187
Alex Sannikov (xalechez) merged 1 commit into
mainfrom
no-jira-update-dev-deps

Conversation

@olliecurtis

@olliecurtis Ollie Curtis (olliecurtis) commented Mar 27, 2024

Copy link
Copy Markdown
Member

Adding @babel/plugin-proposal-private-property-in-object as this solves the output warning that consumers get when installing BRS

One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

When you install the recommended dependency either in the consumer or this project it presents

npm WARN deprecated @babel/plugin-proposal-private-property-in-object@7.21.11: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.

So this installs the correctly required package!

dominicfraser
dominicfraser previously approved these changes Mar 27, 2024
@xalechez Alex Sannikov (xalechez) merged commit 15ac238 into main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants