[No JIRA]SplitChunks remove name and SubresourceIntegrityPlugin use new import syntax#146
Conversation
Jayson Wu (jaysonwu991)
left a comment
There was a problem hiding this comment.
Glad that SplitChunk issue has been solved, here it only needs small changes.
| : {}, | ||
| } | ||
| : {}, | ||
| }; |
There was a problem hiding this comment.
Good to use some common code to implement this functionality, no need to have a deep structure of code.
| const bpkReactScriptsConfig = appPackageJson['backpack-react-scripts'] || {}; | ||
|
|
||
| module.exports = (isEnvDevelopment) => { | ||
| module.exports = isEnvDevelopment => { |
There was a problem hiding this comment.
Is this formation changed by husky hooks when executing git commands?
There was a problem hiding this comment.
This is due to formatting the document, and I will restore it.
| "use strict"; | ||
|
|
||
| const SubresourceIntegrityPlugin = require("webpack-subresource-integrity"); | ||
| const { SubresourceIntegrityPlugin } = require("webpack-subresource-integrity"); |
There was a problem hiding this comment.
Migrate v1 to v5 use new import syntax, see here.
| } | ||
| : { | ||
| ...chunksAndGroups, | ||
| name: false, |
There was a problem hiding this comment.
what is the chunk name looks like for both the name: false and without name case?
There was a problem hiding this comment.
when name is false:
when without name:
So the chunk name is the same when the name: false and without name.
Splitchunks: in webpack5, optimization.splitChunks name: true removed: Automatic names are no longer supported, see here.
sriEnabled: migrate v1 to v5 use new import syntax, see here.
change files:
namewhen development is tureconst SubresourceIntegrityPlugin = require("webpack-subresource-integrity");toconst { SubresourceIntegrityPlugin } = require("webpack-subresource-integrity")