Skip to content

[LEOP-287]Apply all customize features to CRA5-Part2#145

Merged
salleyliu (salleyliu) merged 13 commits into
fork_cra5from
fork_rebase_part2
Apr 27, 2022
Merged

[LEOP-287]Apply all customize features to CRA5-Part2#145
salleyliu (salleyliu) merged 13 commits into
fork_cra5from
fork_rebase_part2

Conversation

@salleyliu

@salleyliu salleyliu (salleyliu) commented Apr 26, 2022

Copy link
Copy Markdown

The part includes updating config and script files and other related files:

  • Add custome features in config file
  • Add ssr config in react-scritps
  • Update denpendencies in react-scripts
  • Update changelog and readme file
  • Remove extra space from the end line: css.html and js.html

@jaysonwu991 Jayson Wu (jaysonwu991) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add #backpack-addons comments and please make sure it is based on the codebase of CRA v5.

Comment thread packages/react-scripts/README.md Outdated
Comment thread packages/react-scripts/README.md Outdated
Comment thread packages/react-scripts/config/paths.js Outdated
Comment thread packages/react-scripts/config/paths.js Outdated
Comment thread packages/react-scripts/config/paths.js Outdated
Comment thread packages/react-scripts/scripts/build.js
Comment thread packages/react-scripts/scripts/build.js
Comment thread packages/react-scripts/scripts/build.js
Comment thread packages/react-scripts/scripts/start-ssr.js
Comment thread packages/react-scripts/scripts/utils/createJestConfig.js
Comment thread packages/react-scripts/config/webpack.config.js Outdated
Comment thread packages/react-scripts/config/webpackDevServer.config.js Outdated
Comment thread packages/react-scripts/config/webpack.config.js Outdated
Comment thread packages/react-scripts/config/webpack.config.js Outdated
Comment thread packages/react-scripts/config/webpack.config.js Outdated
"version": "5.0.0",
"description": "Configuration and scripts for Create React App.",
"name": "@skyscanner/backpack-react-scripts",
"version": "10.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 11.0.0 ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, does Changelog need to add upgrade information now?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please add

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@paultan2021 paul-tan (paultan2021) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/react-scripts/package.json Outdated
Co-authored-by: Jayson Wu <jaysonwu991@outlook.com>
@salleyliu salleyliu (salleyliu) merged commit 71ee671 into fork_cra5 Apr 27, 2022
@olliecurtis Ollie Curtis (olliecurtis) deleted the fork_rebase_part2 branch October 10, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants