Conversation
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 1017 1017
Lines 44438 44436 -2
Branches 3228 3227 -1
==========================================
- Hits 39540 39538 -2
Misses 4176 4176
Partials 722 722
Continue to review full report at Codecov.
|
|
Ready for review. |
| /// </summary> | ||
| public static readonly CieXyz DefaultWhitePoint = Illuminants.D50; | ||
|
|
||
| private static readonly Vector3 Min = new Vector3(0, -200, 0); |
There was a problem hiding this comment.
Public fields should preceed private fields, right? I always get confused by these rules.
There was a problem hiding this comment.
Yep (and why I reordered this one).
There was a problem hiding this comment.
I'm surprised StyleCop hadn't already picked up on this one.
| /// <summary> | ||
| /// Endianness of a converter | ||
| /// </summary> | ||
| internal enum Endianness |
There was a problem hiding this comment.
Debate on coding taste 3 .. 2 .. 1 ...
For me - fine. @JimBobSquarePants ?
There was a problem hiding this comment.
Fine by me, simplicity always wins.
@iamcarbon Did I ever tell you how much I love you 😍 |
| /// to reduce the overhead of small incremental reads. | ||
| /// </summary> | ||
| internal class DoubleBufferedStreamReader : IDisposable | ||
| internal sealed class DoubleBufferedStreamReader : IDisposable |
There was a problem hiding this comment.
Ah yes.... We should be sealing everything we can actually. There's definite advantages in the new compilers.
There was a problem hiding this comment.
Totally. There are some cases where it can avoid virtual calls when sealing the class. I think we've already got most of them.
|
I think this is a good chunk of stuff for this round of nits. :) |
|
@iamcarbon Just a heads up, those failed builds... Each pushed commit triggers a new build so I'm keeping an eye on things and cancelling all but the latest build each time you push to save build time. |
|
|
|
@JimBobSquarePants thanks! not sure how i missed that stylecop violation. |
This reverts commit d22f2a6.
|
success |
Prerequisites
Description
A few small nits.