Allow Build with Visual Studio For Mac#833
Merged
JimBobSquarePants merged 1 commit intomasterfrom Feb 11, 2019
Merged
Conversation
dlemstra
approved these changes
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=========================================
- Coverage 88.84% 88.75% -0.1%
=========================================
Files 1015 1015
Lines 44167 44167
Branches 3181 3181
=========================================
- Hits 39241 39201 -40
- Misses 4201 4206 +5
- Partials 725 760 +35
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=========================================
- Coverage 88.84% 88.75% -0.1%
=========================================
Files 1015 1015
Lines 44167 44167
Branches 3181 3181
=========================================
- Hits 39241 39201 -40
- Misses 4201 4206 +5
- Partials 725 760 +35
Continue to review full report at Codecov.
|
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
This was referenced Jul 30, 2025
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Visual Studio for Mac has a pretty sever limitation when building multitargeting projects.
https://bugzilla.xamarin.com/show_bug.cgi?id=55508#c5
This PR reorders the target frameworks so that
netcoreapp2.1is the first target in all relevant projects and adds the target to ImageSharp.Drawing (we'll probably need it for future perf work anyway).