Skip to content

Solving issue with terminated SSL on load-balancer #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaellwest merged 1 commit into from
Dec 2, 2022
Merged

Solving issue with terminated SSL on load-balancer #1295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions src/Spe/Core/Settings/Authorization/WebServiceSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Xml;
using Sitecore;
Expand All @@ -17,7 +16,7 @@ private class ServiceState
public bool RequireSecureConnection { get; set; }
}

private static readonly Dictionary<string,ServiceState> services = new Dictionary<string,ServiceState>();
private static readonly Dictionary<string, ServiceState> services = new Dictionary<string, ServiceState>();

public const string ServiceRestfulv1 = "restfulv1";
public const string ServiceRestfulv2 = "restfulv2";
Expand All @@ -29,7 +28,7 @@ private class ServiceState
public const string ServiceMediaDownload = "mediaDownload";
public const string ServiceMediaUpload = "mediaUpload";
public const string ServiceHandleDownload = "handleDownload";

static WebServiceSettings()
{
var servicesNodes = Factory.GetConfigNode("powershell/services").ChildNodes;
Expand All @@ -45,7 +44,7 @@ static WebServiceSettings()
Enabled = xmlDefinition.Attributes["enabled"]?.Value?.Is("true") == true,
RequireSecureConnection = xmlDefinition.Attributes["requireSecureConnection"]?.Value?.Is("true") == true
};
services.Add(xmlDefinition.Name,service);
services.Add(xmlDefinition.Name, service);
}

CommandWaitMillis = Sitecore.Configuration.Settings.GetIntSetting("Spe.CommandWaitMillis", 25);
Expand All @@ -54,7 +53,7 @@ static WebServiceSettings()
AuthorizationCacheExpirationSecs = Sitecore.Configuration.Settings.GetIntSetting("Spe.AuthorizationCacheExpirationSecs", 10);
var settingStr = Sitecore.Configuration.Settings.GetSetting("Spe.SerializationSizeBuffer", "5KB");
var sizeLong = StringUtil.ParseSizeString(settingStr);
SerializationSizeBuffer = (int) (sizeLong < int.MaxValue ? sizeLong : int.MaxValue);
SerializationSizeBuffer = (int)(sizeLong < int.MaxValue ? sizeLong : int.MaxValue);
}

public static int CommandWaitMillis { get; private set; }
Expand All @@ -70,8 +69,32 @@ public static bool IsEnabled(string serviceName)
return false;
}
var service = services[serviceName];
return service.Enabled &&
(HttpContext.Current == null || !service.RequireSecureConnection || HttpContext.Current.Request?.IsSecureConnection == true);
return service.Enabled && CheckSecureConnectionRequirement(service);
}

private static bool CheckSecureConnectionRequirement(ServiceState stateOfService)
{
if (HttpContext.Current == null || HttpContext.Current.Request == null)
{
return true;
}

if (!stateOfService.RequireSecureConnection)
{
return true;
}

if (HttpContext.Current.Request.IsSecureConnection == true)
{
return true;
}
else
{
// need to check, if request was offloaded on edge web server
return HttpContext.Current.Request.Headers["X-Forwarded-Proto"].Equals(Uri.UriSchemeHttps, StringComparison.OrdinalIgnoreCase);
}
}

}
}
}