Add-Rendering with specified Rendering Parameters overwrites unspecified Standard Values

[bic742]

Expected Behavior

When using the Add-Rendering command with specified rendering parameters, the rendering gets added with standard value rendering parameters, and then the specified parameters are overridden. The result is that all rendering parameters for the new rendering have a value.

Actual Behavior

When using the Add-Rendering command with specified rendering parameters, the rendering is added with the specified parameters and all other parameters are blank. This is effectively overriding the standard values for any parameter that is not manually specified.

Steps to Reproduce the Problem

Please include the version number of SPE and Sitecore.

• Tested issue with clean install of Sitecore and the latest available version of SPE.

• Asked questions on the Sitecore Slack Chat channel.

• Reviewed questions and answers on the Sitecore Stack Exchange.

[michaellwest]

Wrote this script to help troubleshooting the values that are currently on an item's rendering and what comes from the Standard Values for the rendering.

$item = Get-Item -Path "master:" -ID "{8493AF0C-B135-4E24-B1B0-89C4A0B3DFCD}"
$excludedFields = @("placeholder", "data source", "caching", "personalization", "test")
$renderings = Get-Rendering -Item $item -FinalLayout
foreach($rendering in $renderings) {
    $renderingItem = Get-Item -Path "master:" -ID $rendering.ItemId
    Write-Host "$($renderingItem.Name) $($renderingItem.ID)" -ForegroundColor Green
    Write-Host "Parameters"
    $parameters = (New-Object Sitecore.Text.UrlString $rendering.Parameters).Parameters
    foreach($key in $parameters) {
        Write-Host " $($key) : $($parameters[$key])"
    }
    Write-Host "Standard Values"
    $standardValuesItem = [Sitecore.Data.Items.RenderingItem]::GetStandardValuesItemFromParametersTemplate($renderingItem)
    foreach($field in $standardValuesItem.Fields | Where-Object { $excludedFields -notcontains $_.Name -and [Sitecore.Data.Items.RenderingItem]::IsRenderingParameterField($_) }) {
        Write-Host " $($field.Name) : $($field.Value)"
    }
}

Produces something like the following:

Adding renderings to the item with this script:

$item = Get-Item -Path "master:" -ID "{A2F6CE57-AD71-4911-8733-002A209B43D1}"
$renderingItem = Get-Item -Path "master:/sitecore/layout/Renderings/Sample/Sample Rendering"
$newRendering = New-Rendering -Item $renderingItem
Add-Rendering -Item $item -Instance $newRendering -PlaceHolder "/main/centercolumn/content" -Parameter @{"IsCool"=""} -FinalLayout

[michaellwest]

Relates to this code:

Console/src/Spe/Commands/Presentation/AddRenderingCommand.cs

Line 53 in be3e59e

if (Parameter != null)

[michaellwest]

With the current changes this is what results I see.

Looking at excluding the "Additional Parameters" too.

[michaellwest]

Now additional parameters are excluded.

[michaellwest]

@bic742 Any chance you could run some tests with the latest code to validate my changes?

[bic742]

I ran a quick test, and confirmed this is working.