Conversation
Member
tajobe
commented
Mar 13, 2022
- MC 1.18
- Java 17
- Kotlin 1.6
- Some formatting fixes
- Fix now-deprecated kotlin calls
- Latest versions of our actions steps (least confident in the release plugin update, will have to test a release...)
tajobe
commented
Mar 13, 2022
| - uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: 11 | ||
| - uses: actions/cache@v1 |
Member
Author
There was a problem hiding this comment.
FWIW, cache is not recommended when using the gradle-build-action:
When using gradle-build-action we recommend that you not use actions/cache or actions/setup-java@v2 to explicitly cache the Gradle User Home. Doing so may interfere with the caching provided by this action.
tajobe
commented
Mar 13, 2022
|
|
||
| repositories { | ||
| jcenter() | ||
| mavenCentral() |
Puremin0rez
approved these changes
Mar 13, 2022
| else -> type.name.lowercase().split('_').joinToString(separator = " ", transform = String::titlecaseFirstChar) | ||
| } | ||
|
|
||
| fun String.titlecaseFirstChar() = replaceFirstChar(Char::titlecase) |
Member
There was a problem hiding this comment.
Did they remove / deprecate capitalize in kotlin?! That's definitely going to effect some of my projects lol
Member
Author
There was a problem hiding this comment.
Deprecated in 1.5: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.text/capitalize.html
...I think they did it because it wasn't actually clear what the behavior was by name alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.