Skip to content

ATO-4761: Fix Verification URLs in sift-ruby #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vterlyha-sift merged 16 commits into from
Apr 7, 2025
Merged

ATO-4761: Fix Verification URLs in sift-ruby #97

vterlyha-sift merged 16 commits into from
Apr 7, 2025

Conversation

@vterlyha-sift
Copy link
Contributor

@vterlyha-sift vterlyha-sift commented Apr 3, 2025 •
edited
Loading

Purpose

  • Fix Verification URLs in sift-ruby

Summary

  • For now wrong version of Verifications API is passed in the URL so user receive 404 response when trying to use client

Testing

  • Tested localy and by running unit and integration tests

Checklist

  • The change was thoroughly tested manually
  • The change was covered with unit tests
  • The change was tested with real API calls (if applicable)
  • Necessary changes were made in the integration tests (if applicable)
  • New functionality is reflected in README

@vterlyha-sift
Copy link
Contributor Author

vterlyha-sift commented Apr 3, 2025

/jenkins-test

ykochetkov-sift
ykochetkov-sift reviewed Apr 3, 2025
View reviewed changes
Copy link

@ykochetkov-sift ykochetkov-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also bump library version (similar to 4c7d93d )

@vterlyha-sift
Copy link
Contributor Author

vterlyha-sift commented Apr 3, 2025

Should we also bump library version (similar to 4c7d93d )

Yes, this is mentioned in Runbook

@vterlyha-sift
Copy link
Contributor Author

vterlyha-sift commented Apr 4, 2025

Test - ruby

ykochetkov-sift
ykochetkov-sift reviewed Apr 4, 2025
View reviewed changes
Copy link

@ykochetkov-sift ykochetkov-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also make changes in history file

mlunney
mlunney approved these changes Apr 4, 2025
View reviewed changes
Copy link

@mlunney mlunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vterlyha-sift
Copy link
Contributor Author

vterlyha-sift commented Apr 7, 2025

Could you please also make changes in history file

Updated. Thanks for noticing it!

ykochetkov-sift
ykochetkov-sift approved these changes Apr 7, 2025
View reviewed changes
Copy link

@ykochetkov-sift ykochetkov-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vterlyha-sift vterlyha-sift merged commit 9042213 into master Apr 7, 2025
2 checks passed
@vterlyha-sift vterlyha-sift deleted the vterlyha_fix_verifications_api_version branch April 7, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ykochetkov-sift ykochetkov-sift ykochetkov-sift approved these changes

+1 more reviewer

@mlunney mlunney mlunney approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vterlyha-sift @mlunney @ykochetkov-sift