ci: drop build + tests from the pre-push hook#88
Merged
Conversation
Pre-push ran `dotnet build` + `dotnet test`, duplicating the PR CI gate while diverging from it (no --locked-mode, different SDK/OS), adding minutes to every non-docs push, and — bypassable with --no-verify — never being a hard gate. It had also grown a docs-only skip script that re-implemented CI's changed-files logic locally. Remove the pre-push hook and its build/test task group; CI (`pr.yml`) remains the authoritative build/test gate. The fast pre-commit CSharpier check stays. ADR 0025, README, and CONTRIBUTING updated (EN + JP).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slims the local git hooks so build + tests are owned by CI, not the pre-push hook.
Why
Pre-push ran
dotnet build+dotnet test --filter "Category!=Integration"on every non-docs push. That:pr.ymlalready builds/tests) while diverging from it — the local run has no--locked-modeand a different SDK/OS, so a local pass didn't imply a CI pass and a local failure was sometimes environmental;--no-verify— was never a hard gate;What
.husky/pre-pushand itsbuild/testtask group from.husky/task-runner.json. The docs-only skip script goes with it.pr.yml) remains the authoritative build/test gate.No product code changes.