Conversation
This comment has been minimized.
This comment has been minimized.
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
|
/snapit |
|
🫰✨ Thanks @juanpprieto! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/cli-hydrogen": "0.0.0-snapshot-20250415170037",
"@shopify/hydrogen": "0.0.0-snapshot-20250415170037",
"@shopify/mini-oxygen": "0.0.0-snapshot-20250415170037"
|
|
👍 |
|
@juanpprieto Any chance this broke Vite 5 users? We have a hydrogen E2E test application that's still built with Vite 5 and Btw, we purposefully don't use a lockfile so this is likely not an issue that too many people run into. Just wanted to let you know anyway :) |
…6158) Seems like `@shopify/mini-oxygen@3.2.1` breaks something. I somewhat suspect that they bumped a vite version but I didn't find a changelog yet This should unblock the PRs we want to include in Today's release Update: Shopify/hydrogen#2863 likely caused this
* Update resolve conditions for vite 6
Replaces #2840
closes #2858 ✅
Context:
https://shopifypartners.slack.com/archives/C02F94JC3QC/p1743413107901139
sanity-io/hydrogen-sanity#116
sanity-io/visual-editing#1085
Vite 6 (2025.1.3+) seems to have a different more strict NPM module resolution logic for worker exports. This PR aims to fix this by adding an additional resolve conditions for workers in the SSR option.