Normalize paths in deprecation messages#60
Draft
sambostock wants to merge 7 commits into
Draft
Conversation
Without capturing logs, the warning makes it to stderr. By capturing, we can not only assert that it would have made it, but prevent it from actually appearing in the test output.
5c8d89f to
cd181b7
Compare
cd181b7 to
8bf5008
Compare
|
@Edouard-chin is there any interest in incorporating something like this PR? I have run into a different problem that was solvable with this same concept. In my case, we have a deprecation warning that includes a whole hash object in the message, making it unstable between test runs. I needed to transform the message before persisting, to "redact" the variable part so it can be logged as a generic message:
I used a slightly more generic idea of "transformations" on the event payload that adds a little more flexibility, but I could have accomplished this with the normalizers in the original PR as well: module DeprecationToolkit
class Configuration
config_accessor(:transformations) { [] }
end
class DeprecationSubscriber < ActiveSupport::Subscriber
def deprecation(event)
event.payload = Configuration
.transformations
.reduce(event.payload) { |payload, transformation| transformation.call(payload) }
super(event)
end
end
end
DeprecationToolkit::Configuration.transformations = [
->(payload) {
re = /(.*json\/encoding\.rb.*warning: detected duplicate key "\w+") in .*\.\s*(This will raise an error.*)/
re.match(payload[:message]) do |matchdata|
payload[:message] = "#{matchdata[1]}. #{matchdata[2]}"
end
payload
}
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This (tentatively) adds support for registering deprecation message normalizers, and provides built in normalization of paths by looking for the following strings:
Dir.pwd, which are replaced with#{Dir.pwd}Gem.path's paths, which are replaced with#{Gem.path[index]}, whereindexis the index of the path in theGem.patharrayReplacements are made to look like interpolation, so it is clear what they represent.
This should resolve #48.
README.mdCHANGELOG.md