Stop loading overlay when extension is disabled#29
Merged
Shantanugupta43 merged 1 commit intoShantanugupta43:mainfrom Mar 31, 2026
Merged
Conversation
Owner
|
Hey thanks for your contributions I will have a look and would review after 3 days. Cheers :) |
Shantanugupta43
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Summary
Prevents the content script from showing the temporary "Thinking..." overlay when the extension has been disabled.
Changes
Validation
Why this fixes the bug
The service worker already avoids API calls when disabled, but the content script was showing the loading overlay before that check. This moves the disabled-state gate into the content script so the overlay never appears in the first place.