Skip to content

Add filters#14

Merged
loevgaard merged 1 commit into
masterfrom
add-filters
Jul 14, 2023
Merged

Add filters#14
loevgaard merged 1 commit into
masterfrom
add-filters

Conversation

@loevgaard

Copy link
Copy Markdown
Member

This PR adds two types of filters

  • Path based
  • Hostname based

The idea with filters is to exclude the tracking on certain paths (e.g. /admin) or domains (e.g. api.example.com).

@loevgaard loevgaard force-pushed the add-filters branch 2 times, most recently from 049f790 to 04c4793 Compare July 14, 2023 12:25
@codecov

codecov Bot commented Jul 14, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 54.90% and project coverage change: +8.84 🎉

Comparison is base (79ac0bd) 26.53% compared to head (b046388) 35.38%.

❗ Current head b046388 differs from pull request most recent head 3371a36. Consider uploading reports for the commit 3371a36 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #14      +/-   ##
============================================
+ Coverage     26.53%   35.38%   +8.84%     
- Complexity       72      101      +29     
============================================
  Files            20       28       +8     
  Lines           245      342      +97     
============================================
+ Hits             65      121      +56     
- Misses          180      221      +41     
Impacted Files Coverage Δ
src/DependencyInjection/Configuration.php 0.00% <0.00%> (ø)
src/EventSubscriber/Tag/EventSubscriber.php 0.00% <0.00%> (ø)
src/EventSubscriber/Tag/LibrarySubscriber.php 0.00% <0.00%> (ø)
...rc/Filter/ClientSide/CompositeClientSideFilter.php 0.00% <0.00%> (ø)
src/SetonoGoogleAnalyticsBundle.php 0.00% <0.00%> (ø)
src/ValueObject/Property.php 0.00% <0.00%> (ø)
...ilter/ClientSide/HostnameBasedClientSideFilter.php 94.44% <94.44%> (ø)
...rc/Filter/ClientSide/PathBasedClientSideFilter.php 94.73% <94.73%> (ø)
...ndencyInjection/SetonoGoogleAnalyticsExtension.php 97.22% <100.00%> (+0.44%) ⬆️
src/Filter/Matcher/EqualityMatcher.php 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loevgaard loevgaard force-pushed the add-filters branch 6 times, most recently from 2c9dcdb to 6baf9c1 Compare July 14, 2023 13:10
@loevgaard loevgaard merged commit d52b5ee into master Jul 14, 2023
@loevgaard loevgaard deleted the add-filters branch July 14, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant