Merged
Conversation
Contributor
Author
|
@RaymondLi0 if you have some time to double check this |
Collaborator
|
Approach looks great! |
RaymondLi0
reviewed
Aug 18, 2025
Contributor
RaymondLi0
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Added a few comments, otherwise LGTM
fast_llm/layers/ssm/mamba2.py
Outdated
| delta_softplus=True, | ||
| ) | ||
| if not _mamba_varlen: | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe throw an error here if cu_seqlens is not None, saying that this version of mamba does not support varlen inputs
| @@ -0,0 +1,65 @@ | |||
| import logging | |||
Contributor
There was a problem hiding this comment.
let's call this file preprocessing.py to follow other layers
| """ | ||
| Simplified preprocessor that does not take into account micro-sequences. | ||
| """ | ||
| sequence_lengths = kwargs[TransformerKwargs.sequence_lengths] |
Contributor
There was a problem hiding this comment.
if TransformerKwargs.sequence_lengths not in kwargs, there is nothing to do.
(iiuc this is the case when cross_document_attention is set to True.)
fast_llm/layers/ssm/preprocessors.py
Outdated
| Simplified preprocessor that does not take into account micro-sequences. | ||
| """ | ||
| sequence_lengths = kwargs[TransformerKwargs.sequence_lengths] | ||
| if "cu_seqlens" in kwargs: |
Contributor
There was a problem hiding this comment.
Suggested change
| if "cu_seqlens" in kwargs: | |
| if TransformerKwargs.cu_seqlens in kwargs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Varlen mamba to enable packing.
🔍 Type of change
Select all that apply:
📝 Changes
List the key changes introduced in this PR:
✅ Checklist
Make sure the following tasks are completed before submitting the PR:
General
Dependencies and Configuration
Testing
Performance Impact
📊 Performance Impact Details
If there is any impact on performance, describe it and provide benchmark results, if applicable:
🗒️ Additional Notes
Include any additional context, information, or considerations here, such as known issues, follow-up tasks, or backward compatibility concerns.