Add model prefix validation to PR review workflow#648
Merged
functionstackx merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
Add validation rule to ensure config keys only use valid model prefixes (dsr1 or gptoss). Invalid prefixes like dsr1-fp8 will now trigger a BLOCKING comment explaining that it breaks the frontend. Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a validation rule to the Claude PR review workflow to ensure that config keys in master config files only use valid model prefixes (
dsr1orgptoss).Why this is needed:
dsr1andgptossas model prefixesdsr1-fp8breaks the frontend and prevents benchmark results from being displayedChanges:
.github/workflows/claude-pr-review.ymlRelated context: See discussion in PR #627 where
dsr1-fp8prefix was identified as breaking the frontend.🤖 Generated with Claude Code