Add enroot import validation for launch scripts in PR review#596
Merged
functionstackx merged 2 commits intomainfrom Jan 29, 2026
Merged
Add enroot import validation for launch scripts in PR review#596functionstackx merged 2 commits intomainfrom
functionstackx merged 2 commits intomainfrom
Conversation
Add PR review validation to warn when runners/launch_*.sh scripts don't transform public Docker images to enroot local images using the enroot import pattern. This ensures benchmark reproducibility. Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runners/launch_*.shscripts don't transform public Docker images to enroot local imagesenroot import -o $SQUASH_FILE docker://$IMAGEpatternWhy this matters
Test plan
🤖 Generated with Claude Code
Triggered from: https://github.com/InferenceMAX/InferenceMAX/pull/588#discussion_r2739397836