Skip to content

Update README formatting#3

Closed
nschonni wants to merge 3 commits into
SeleniumHQ:masterfrom
nschonni:patch-1
Closed

Update README formatting#3
nschonni wants to merge 3 commits into
SeleniumHQ:masterfrom
nschonni:patch-1

Conversation

@nschonni

Copy link
Copy Markdown
Contributor

Empty brackets cause the markdown to swallow the links. Opted for raw links over using the site name as the anchor.

Empty brackets cause the markdown to swallow the link. Opted for raw links over using the site name as the anchor
@lukeis

lukeis commented Jan 15, 2013

Copy link
Copy Markdown
Member

This may sound a bit silly for this change, but can you please confirm you have signed the CLA:
http://goo.gl/qC50R

@nschonni

Copy link
Copy Markdown
Contributor Author

Yes, I did after I submitted. Maybe it got stuck in the tubes.
PS: I noticed the were a few more GitHub casing issues in the README

@lukeis

lukeis commented Jan 15, 2013

Copy link
Copy Markdown
Member

thanks :) (we just ask because there's only one individual who can actually read the CLA and often trust the word of the user).

Let me know if you want to make those additional changes and I'll wait for an update to the pull request

@nschonni

Copy link
Copy Markdown
Contributor Author

Sure, I'll temporarily close this and make the additional changes when I'm home

@nschonni nschonni closed this Jan 15, 2013
@nschonni

Copy link
Copy Markdown
Contributor Author

Fixed GitHub casing and the power git checkout link

@nschonni nschonni reopened this Jan 16, 2013
@lukeis

lukeis commented Jan 16, 2013

Copy link
Copy Markdown
Member

Merged in revision 67ce103 (this mirror will be updated soon).

Also I squashed the commits. Thanks for the patch :)

@lukeis lukeis closed this Jan 16, 2013
@nschonni

Copy link
Copy Markdown
Contributor Author

No problem, I forgot about the quash bit.
What about adding something like this SeleniumBuilder/se-builder#5 with the additional GitHub specific info?

@lukeis

lukeis commented Jan 16, 2013

Copy link
Copy Markdown
Member

Yes, something like that would be good, although the wiki is on googlecode and not github:
http://code.google.com/p/selenium/w/list

And probably just an adjustment of http://code.google.com/p/selenium/wiki/GettingInvolved (or extra info)
That lives in this repo:
http://code.google.com/p/selenium/source/browse/GettingInvolved.wiki?repo=wiki
(you can submit a patch to the google code wiki by clicking the 'edit' button on that page)

@nschonni nschonni deleted the patch-1 branch January 16, 2013 16:52
IlyaNaumovich added a commit to IlyaNaumovich/selenium that referenced this pull request Feb 11, 2018
dev-velo added a commit to dev-velo/selenium that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants