Skip to content

[rb] Add copyright header for client_config.rbs - #17722

Merged
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:rb-format-issue
Jun 28, 2026
Merged

[rb] Add copyright header for client_config.rbs#17722
nvborisenko merged 1 commit into
SeleniumHQ:trunkfrom
nvborisenko:rb-format-issue

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

Fix format rb issue in trunk.

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

@selenium-ci selenium-ci added the C-rb Ruby Bindings label Jun 28, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add Apache 2.0 copyright header to client_config.rbs
📝 Documentation 🕐 Less than 5 minutes

Grey Divider

Description

• Add standard Apache 2.0 license header to the Ruby RBS signature file.
• Align file formatting with repository licensing/header conventions.
High-Level Assessment

The change is the standard and expected approach: add the project’s canonical Apache 2.0 header to the missing signature file. Alternatives (e.g., relying on directory-level licensing) are typically less explicit and can conflict with automated header/format checks.

Files changed (1) +18 / -0

Documentation (1) +18 / -0
client_config.rbsAdd Apache 2.0 license header comment block +18/-0

Add Apache 2.0 license header comment block

• Prepends the standard Software Freedom Conservancy / Apache 2.0 license header to the RBS signature file. This is a non-functional change intended to satisfy repository formatting/licensing expectations.

rb/sig/lib/selenium/webdriver/common/client_config.rbs

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@nvborisenko
nvborisenko merged commit 6f7ddb3 into SeleniumHQ:trunk Jun 28, 2026
20 checks passed
@nvborisenko
nvborisenko deleted the rb-format-issue branch June 28, 2026 13:02
This was referenced Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-rb Ruby Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants