Skip to content

[build] Automated Browser Version Update - #17687

Merged
diemol merged 3 commits into
trunkfrom
pinned-browser-updates
Jun 19, 2026
Merged

[build] Automated Browser Version Update#17687
diemol merged 3 commits into
trunkfrom
pinned-browser-updates

Conversation

@selenium-ci

Copy link
Copy Markdown
Member

This is an automated pull request to update pinned browsers and drivers

Merge after verifying the new browser versions are properly passing the tests

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jun 17, 2026
@selenium-ci
selenium-ci force-pushed the pinned-browser-updates branch from a35b44e to 4ae4e55 Compare June 18, 2026 01:27
@selenium-ci
selenium-ci force-pushed the pinned-browser-updates branch from 51e0b5c to dc47707 Compare June 19, 2026 01:31
Bug was fixed in Firefox 152; guards are no longer needed now that pinned
browser has been updated to 152+.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@qodo-code-review

qodo-code-review Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 22 rules

Grey Divider


Remediation recommended

1. Linux Edge pin skew 🐞 Bug ≡ Correctness
Description
common/repositories.bzl updates the pinned Linux Edge browser to 149.0.4022.80 but leaves
linux_edgedriver pinned to 149.0.4022.69, so pinned Linux Edge runs pair a newer browser with an
older driver. This violates the repository’s own generation intent to pin compatible Edge/EdgeDriver
pairs per-platform and can lead to Linux Edge test setup failures or flakiness when the
driver/browser compatibility is stricter than “same major version”.
Code

common/repositories.bzl[R144-147]

    deb_archive(
        name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.69-1_amd64.deb",
-        sha256 = "d14afed0a28943b553afb20c6b1e41220c127fa8cd86bd008b3f92a3b1e3fce1",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.80-1_amd64.deb",
+        sha256 = "e6b1d2317f47771bd0390d370e72c917b3531d8e586edeec494e4cadc1b34676",
Evidence
The pinned Linux Edge browser version is now 149.0.4022.80-1, while the pinned Linux EdgeDriver
URL still targets 149.0.4022.69. The repository’s generator script states it ensures
Edge/EdgeDriver compatibility and emits both pins per platform, and the Bazel wiring for pinned
Linux Edge pulls both the linux browser and linux driver artifacts together—making this skew a real
configuration inconsistency.

common/repositories.bzl[144-170]
common/browsers.bzl[32-52]
scripts/pinned_browsers.py[335-368]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The pinned Linux Edge browser was bumped to `149.0.4022.80`, but the pinned Linux EdgeDriver (`msedgedriver`) stayed at `149.0.4022.69`. This creates a skew between the pinned browser and driver on Linux.

## Issue Context
The pin-generation script explicitly aims to fetch Edge and EdgeDriver “ensuring versions are compatible”, and the build/test wiring for pinned Linux Edge consumes both `@linux_edge` and `@linux_edgedriver` together.

## Fix Focus Areas
- common/repositories.bzl[144-170]
- scripts/pinned_browsers.py[335-368]
- common/browsers.bzl[32-52]

## Suggested fix
Update `linux_edgedriver` to the matching `149.0.4022.80` release (and update its `sha256`), ideally by re-running `bazel run scripts:pinned_browsers` so the file is regenerated consistently for both mac and linux.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Previous review results

Review updated until commit 3125877

Results up to commit 20fcda7


🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)


Remediation recommended
1. Linux Edge pin skew 🐞 Bug ≡ Correctness
Description
common/repositories.bzl updates the pinned Linux Edge browser to 149.0.4022.80 but leaves
linux_edgedriver pinned to 149.0.4022.69, so pinned Linux Edge runs pair a newer browser with an
older driver. This violates the repository’s own generation intent to pin compatible Edge/EdgeDriver
pairs per-platform and can lead to Linux Edge test setup failures or flakiness when the
driver/browser compatibility is stricter than “same major version”.
Code

common/repositories.bzl[R144-147]

    deb_archive(
        name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.69-1_amd64.deb",
-        sha256 = "d14afed0a28943b553afb20c6b1e41220c127fa8cd86bd008b3f92a3b1e3fce1",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.80-1_amd64.deb",
+        sha256 = "e6b1d2317f47771bd0390d370e72c917b3531d8e586edeec494e4cadc1b34676",
Evidence
The pinned Linux Edge browser version is now 149.0.4022.80-1, while the pinned Linux EdgeDriver
URL still targets 149.0.4022.69. The repository’s generator script states it ensures
Edge/EdgeDriver compatibility and emits both pins per platform, and the Bazel wiring for pinned
Linux Edge pulls both the linux browser and linux driver artifacts together—making this skew a real
configuration inconsistency.

common/repositories.bzl[144-170]
common/browsers.bzl[32-52]
scripts/pinned_browsers.py[335-368]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The pinned Linux Edge browser was bumped to `149.0.4022.80`, but the pinned Linux EdgeDriver (`msedgedriver`) stayed at `149.0.4022.69`. This creates a skew between the pinned browser and driver on Linux.

## Issue Context
The pin-generation script explicitly aims to fetch Edge and EdgeDriver “ensuring versions are compatible”, and the build/test wiring for pinned Linux Edge consumes both `@linux_edge` and `@linux_edgedriver` together.

## Fix Focus Areas
- common/repositories.bzl[144-170]
- scripts/pinned_browsers.py[335-368]
- common/browsers.bzl[32-52]

## Suggested fix
Update `linux_edgedriver` to the matching `149.0.4022.80` release (and update its `sha256`), ideally by re-running `bazel run scripts:pinned_browsers` so the file is regenerated consistently for both mac and linux.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Qodo Logo

The PKG extraction fails on Firefox 153.0b1 with a cpio "bad magic value"
error because Mozilla changed the internal pkg format. Mozilla ships DMG
for all modern macOS releases anyway, so always use DMG on macOS.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 3125877

@diemol
diemol merged commit 54ad310 into trunk Jun 19, 2026
63 checks passed
@diemol
diemol deleted the pinned-browser-updates branch June 19, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants