You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the test website, there were some typos in the site like Long instead of Log in - https://www.selenium.dev/selenium/web/logEntryAdded.html and others which were fixed in previous commits but were not updated in the gh-pages branch.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
Cleanup (formatting, renaming)
PR Type
Documentation
Description
Fix typo in log entry test pages
Add new FedCM and service worker test pages
Improve relative locators HTML structure and styling
Update form page select options visibility
Diagram Walkthrough
flowchart LR
A["Typo Fixes"] --> B["Test Pages"]
C["New Pages"] --> B
D["HTML Structure"] --> B
B --> E["Updated Test Website"]
The configURL construction uses template literals with location.host which may not work correctly in all test environments and could cause issues with different host configurations.
let configURL = `http://${location.host}/common/fedcm/config.json`;
console.log(configURL)
The JavaScript package path has been changed from node/selenium-webdriver to selenium-webdriver which may break existing build dependencies or references.
Why: The suggestion correctly adds a .catch block to handle potential errors during service worker registration, which is crucial for debugging and robust error handling.
Medium
Security
Use protocol-relative URL construction
Using http:// protocol in template literals can cause security issues and mixed content warnings on HTTPS sites. Consider using protocol-relative URLs or checking the current protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
💥 What does this PR do?
Updates the test website, there were some typos in the site like
Longinstead ofLogin - https://www.selenium.dev/selenium/web/logEntryAdded.html and others which were fixed in previous commits but were not updated in thegh-pagesbranch.🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Documentation
Description
Fix typo in log entry test pages
Add new FedCM and service worker test pages
Improve relative locators HTML structure and styling
Update form page select options visibility
Diagram Walkthrough
File Walkthrough